Repository navigation
Verify The Dig - #825
Open
mark-wd wants to merge 1 commit into
Open
Verify The Dig#825mark-wd wants to merge 1 commit into
mark-wd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying The Dig (1995) (LucasArts)
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
No installation is required for the existing CD-image package. The game runs from the mounted CD, and the DOSC supplies
C:\DIG\IMUSE.INIfor Sound Blaster 16 audio.Have any official patches been applied, if necessary?
No additional patch was applied. This verifies the existing English 1.00 disc release, matching Redump disc 2104.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes. The DOSZ contains only
Dig, The (USA, Europe).chdat its root. The original disc filesystem is preserved inside the CHD.Is the entry in the right variant file (i.e. Freeware)?
Yes. This promotes the existing primary commercial release to
PureDOSDAT.xml.Have digital versions (Steam, GOG) been checked for matching?
The GOG and Steam listings were checked. Their current payloads were not obtained for a byte-for-byte comparison. This PR verifies only the existing Redump-matched CD release.
Can the game benefit from using embedded data or embedded patches in the datfile?
No additional embedded data or patches are needed. DoDAT builds the existing CHD member from the matching BIN/CUE source.
Can DoDAT build the game from the install media?
Yes. DoDAT v0.8 successfully rebuilt the DOSZ from the preserved BIN/CUE source and reported
[OK] Correctly matched all 1 romsduring full SHA-1 verification. The source BIN has SHA-1725c23b6c7718fa61249b4ce59179acb8cfb1ab1.If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
DOS.YMLis inside the DOSC; the DAT has no external YML reference.Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
The original disc image is preserved intact. No files are removed from its filesystem, and no loose Windows files are added to the DOSZ.
Do the file timestamps match the installation media?
The existing DAT specifies no timestamp for the CHD member. Full DoDAT verification passed, and the original disc filesystem and its timestamps remain unchanged.
Does the DOSZ run standalone?
The DOSZ contains the required disc image, with no external media needed. Runtime testing used the matching DOSC; a separate test without the DOSC was not recorded.
For CD games, can the game be set up to run without a CD mounted?
The verified package retains the mounted CD and launches
D:\DIG.EXE. A CD-free extracted-files variant was not evaluated.For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not evaluated. This PR verifies the existing CD-image package and does not propose a new installation variant.
Can the game benefit from using CHDtoOGG?
No. The recorded disc has a single Mode 1 data track and no CD-audio tracks.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No swap file was observed in the inspected runtime overlay. The existing memory settings are unchanged.
Does the DOSC contain problematic data (i.e. copyright issue)?
No. The unchanged DOSC contains only
DOS.YMLand the setup-generatedDIG/IMUSE.INIconfiguration, with no game executable or other game payload.Does the DOSC have copy protection removed, if possible?
No protection patch is included in the DOSC. The original CD image is retained unchanged.
Is the game running at the correct speed? Is CPU year specified?
Runtime validation used the existing
cpu_max_year: 1995setting. No CPU-setting change is proposed.Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
Yes. The existing DOSC launches
D:\DIG.EXEand uses(WAITMODECHANGE)p(WAITMODECHANGE)(WAITMODECHANGE)to select Play from the launcher and advance through startup mode changes.Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
Not separately checked. The existing DOSC uses Sound Blaster 16 configuration.
Does the game have General MIDI support?
Not separately checked. The existing DOSC has no General MIDI launch option.
Is the game set up to run with the best quality graphics options by default?
The existing graphics configuration is retained. Alternate graphics settings were not separately compared.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
No video-card override is configured. Alternate PCjr/Tandy/CGA modes were not separately compared.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
Not separately compared. The existing DOSC leaves
input_directmouseunset.Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
The existing single automatic launch is retained. No additional episode or utility launch options are added.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable. No shared-save relationship is configured and no
.savenamemember is used.Comment
PureDOSDAT.xml.dosc/byte-for-byte unchanged.The Digto satisfy the verified-DAT naming check; filenames and all ROM and track attributes are unchanged.