Repository navigation
Conversation
This was referenced Oct 7, 2026
For Examples 1, 3a, 3b, 4a and 4b: plan the workload, start the data_plane binary against a Prometheus holding generated samples, Remote Write the same samples, and require every planned query to be answered by the plan with the Planner executor's result for the selected logical candidate with nothing materialized (control_plane::plan_selected_at_query_time). 3b also runs, and 4b only runs, on a deployment without raw data, so their panes are built from Remote Write. Exact results must match exactly; Example 3a/4a's five-year KLL windows exceed k and KLL compaction is randomized, so they must agree within twice the 0.005 rank target.
zzylol
force-pushed
the
feat/query-engine
branch
from
October 18, 2026 15:40
6f7b53c to
b1b1e5a
Compare
zzylol
force-pushed
the
test/e2e-examples
branch
from
October 18, 2026 15:40
4ab777a to
f7faf1b
Compare
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 5/5. Base: #821.
Why
First milestone of executing the Planner's plan: the data plane's answers must equal what the Planner executor computes for the same selected plan.
What
data_plane/tests/e2e_examples.rsruns the realdata_planebinary for #509's PromQL Examples 1, 3a, 3b, 4a and 4b:control_plane::plan_selected_at_query_timegives that reference: the Stage 2 candidateP<n>implementing the selected candidate's logical candidateL<n>with nothing materialized, sized for the failure probabilities and with confirmed weights as Stage 3 does for the selected one. Same summaries and parameters, everything at query time.examples/planner-layering-example3a.json(Pattern A, ad hoc at T) and-example4a.json(Pattern A, monthly) are added in the current workload format.P1(exact, query time)P485(KLL k=1246, query time)P2(KLL, query time)P4125(KLL k=1246, query time)P3-m1(10-min KLL panes at ingestion)3a/4a match within a value tolerance of 10, about twice KLL's 0.005 rank error: their five-year windows hold more samples than
k, andasap_sketchlib's KLL seeds compaction from the thread RNG, so two builds abovekcan differ.How
Per example: plan with
plan_workload(the plan installed) andplan_selected_at_query_time(the reference), startdata_plane --allowed-lateness-ms 0, Remote Write every sample, poll each planned query untilx-asap-execution: plan, and compare series by series with the reference run throughQueryEngineover the same samples.Key code interfaces added / modified
Before this PR
No test checked that the data plane's answers match the Planner's.
After this PR
Every example's planned queries are answered by the plan and match the Planner executor (numbers below).
Usage
Verification
cargo test -p data_plane --test e2e_examples(5 tests, about 6 minutes in a debug build: Examples 3a/4a enumerate thousands of candidates).cargo test -p control_plane -p data_plane(control plane addsreference_plan_materializes_nothing),cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings.