Repository navigation
fix(tools): the MetricsQL consumer check uses RequestedAccuracy::exact() - #710
Merged
Merged
Conversation
#708 replaced AccuracyTarget::Exact with constructors and made the frontends take a RequestedAccuracy, so the generated consumer crate no longer compiled and main's test job failed.
zzylol
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
testjob on main fails after #708 (ac3c852a).tools/verify_metricsql_external_consumer.shgenerates a small external crate that still callsAccuracyTarget::Exact, which #708 replaced.What
The generated consumer passes
RequestedAccuracy::exact(), the input typelower_metricsqlnow takes.How
One line in the script's generated
main.rs.Key code interfaces added / modified
None (tooling script only).
tools/verify_metricsql_external_consumer.shnow callslower_metricsqlwithasap_types::types::RequestedAccuracy::exact()instead of the removedAccuracyTarget::Exact, following #708.Before this PR
The consumer crate fails to compile with
no associated function or constant named Exact.After this PR
The consumer crate builds against the frontend's current public API.
Verification
tools/verify_metricsql_external_consumer.shlocally; it finishes cleanly.Follow-up
The check runs only in CI's test job and is easy to miss. Agents now run it whenever a PR changes a frontend's public signature.