Repository navigation
Conversation
zzylol
force-pushed
the
feat/hh-accuracy
branch
2 times, most recently
from
October 19, 2026 20:15
f0b5fe4 to
bffc387
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:15
ab6f04b to
74a8594
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:16
bffc387 to
986f1cb
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:16
74a8594 to
f3d2ad5
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:16
986f1cb to
bb9b0c5
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:16
f3d2ad5 to
971825f
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:16
bb9b0c5 to
3dc60b9
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:16
971825f to
11092ab
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:17
3dc60b9 to
a97a269
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:17
11092ab to
21f5802
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:17
a97a269 to
10782f4
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:17
21f5802 to
05ea8f8
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:18
10782f4 to
f7bb4ba
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
2 times, most recently
from
October 19, 2026 20:18
bfbdb55 to
541925f
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:18
f7bb4ba to
70f9686
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:18
541925f to
7da0bc7
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:18
70f9686 to
2d4a81f
Compare
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:19
7da0bc7 to
c03faab
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:19
2d4a81f to
66e4a95
Compare
A new observer stage, hh-accuracy (urn:asap:processor:heavy_hitter_accuracy), sits outside the three pipelines. In the top-k use case both detectors send it a copy of their answers through the official fanout. Per window and top-k series it takes the heavy hitters as the keys with at least phi (1%) of the window's points by the exact counts, and the sketch's reported keys as those whose estimate reaches the same threshold. It then emits asap.hh.precision, asap.hh.recall, asap.hh.f1, asap.hh.are (mean relative count error over the true positives), asap.hh.truth and asap.hh.reported. About 10 routes reach 1% in this scenario, so the sketch heap and both detectors now report the top 20, and the top-10 panels and checks filter on rank. A window whose exact top 20 is all above the threshold could hide heavy hitters and only gets asap.hh.incomplete. The dashboard gains precision/recall/F1 and ARE panels; acceptance checks precision and recall >= 0.9, and the accuracy-size experiment records them.
zzylol
force-pushed
the
perf/observe-without-allocation
branch
from
October 19, 2026 20:19
c03faab to
26e7bb2
Compare
zzylol
force-pushed
the
feat/hh-accuracy
branch
from
October 19, 2026 20:19
66e4a95 to
5aba1b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 12 of the telemetry-functions stack: identification and counting accuracy of the top-k use case's heavy hitters, live in the demo.
Why
The top-k dashboard showed the sketch's and the exact top-10 side by side, and acceptance checked recall@10. Neither said how well the sketch identifies heavy hitters, or how far off its counts are. A top-10 comparison cannot separate precision from recall either: both lists always have 10 entries.
What
hh-accuracy(urn:asap:processor:heavy_hitter_accuracy,common/hh-accuracy.yaml): a new stage outside the three pipelines; they still share no processor. In the top-k use case both detectors send it a copy of their answers through the officialfanout. Per window and top-k series:asap_hh_precision(TP / reported),asap_hh_recall(TP / truth),asap_hh_f1,asap_hh_are(mean |estimate − exact| / exact over the true positives; the sketch has no count for a heavy hitter it missed),asap_hh_truthandasap_hh_reported.rank. A window whose exact top 20 is entirely above the threshold could still hide heavy hitters; it gets onlyasap_hh_incomplete.hh-accuracy.experiments.py accuracy-sizerecords the four metrics per Count-Min width. CI and compose add the 19th stage (CPU 18).Result (56-core x86 server, 1-minute windows, 2 × 20,000 points/s, Count-Min 4 × 512)
First window on the live demo: 10 heavy hitters by exact, 11 reported by the sketch. Precision 0.91, recall 1.00, F1 0.95, ARE 1.95%. The false positive is the rank-11 route at about 0.97% of the points. Count-Min only overestimates, and its collision error (about 1,000–1,300 points here, 0.05%) lifts it over 1%. That is the precision failure the metric is meant to expose.
Verification
heavy_hitter_accuracyon a hand-checked window (a false positive pushed over the threshold, a missed heavy hitter, ARE over the true positives, the truncated-list case); the node only reports a window after both methods answered, ignores lower/upper bounds, and labels the gauges with the series and φ.cargo fmt --check,cargo clippy --all-targets --features otap-engine(no warnings) andcargo test --features otap-enginepass.