Repository navigation
ci: Run tests on every pull request across PHP 7.1 to 8.4 - #3
Merged
Merged
Conversation
- Run PHPUnit and lint on PHP 7.1 - 8.4 - Check that the generated traits are up to date
PHPUnit 9 requires PHP 7.3 and Composer resolved only PHPUnit 9 on PHP 7.2
("^7.5 || ^9.5"), so dependency installation failed there. Adding ^8.5
gives PHP 7.2 an installable PHPUnit.
PresentKim
force-pushed
the
ci/verify-pull-requests
branch
from
October 7, 2026 06:22
d65b951 to
9e9fa68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a workflow that verifies every pull request. Until now only the benchmark workflow existed (PHP 7.3 and 8.4, on pushes to
main), so the declared minimum of PHP 7.1 was never actually run.Jobs
php -lonsrcandtests/unit, thencomposer test.phpbenchis removed before installing because it does not support the oldest PHP versions and tests do not need it.python3 tools/generate-traits.py --check.The workflow also has
workflow_dispatchso it can be started manually.Other change
composer.json: PHPUnit constraint is now^7.5 || ^8.5 || ^9.5. With^7.5 || ^9.5, Composer could only pick PHPUnit 9 on PHP 7.2, which requires PHP 7.3, so installation failed there.Notes