Repository navigation
fix: except audit from event def write scope - #1491
Merged
Merged
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
johncwaters
approved these changes
Oct 23, 2026
johncwaters
left a comment
johncwaters
left a comment
Contributor
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
Approved by hand after checking the automated review.
| * The signup path mints a token from these scopes. A program's additions | ||
| * must reach its own provisioned tokens and no one else's. | ||
| */ | ||
| // The Live Data step's error-tracking call 403s without it, and the step then skips its whole sweep. |
Contributor
There was a problem hiding this comment.
Note
Automated review. Not written by a human.
[manual-review] LOW
This block landed between the provisioning scopes doc comment ("The signup path mints a token from these scopes...") and the describe it documents, so that comment now reads as describing the audit block. Move the new block and its one-line comment above that doc comment, right after error-tracking scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit shouldn't require write scopes for
event_definition