Repository navigation
Conversation
Nine complete runs on 31 October took 57 to 73 minutes a shard against the 75-minute limit, and the limit cancelled shard 1/6 of run 41191216150 with its tests at 99%. A seventh shard brings the duration-balanced slow tests to about 115 minutes of worker time per shard instead of 134. Job names, outcome artifacts, Result and check_test_shards.py follow the matrix size, so only the matrix, comments and docs change. Fixes #2770 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 31, 2026 15:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2770
Reproducer:
policyengine_uk/tests/code_health/test_ci_test_shards.pyThe Python shards use almost all of the 75-minute job limit, so a slow runner can cancel a job whose tests pass. This adds a seventh shard, the fix
test-suite.yamldocuments.Why
shard_durations.tomlputs the listed slow tests at 134 minutes of worker time per shard on six shards and 115 on seven. The balanced split gives each of the seven shards 115 minutes.What changed
test-suite.yaml: the matrix gains a 7, and a new paragraph above the job records the numbers above.pr_code_changes.yaml,Makefile,docs/engineering/skills/testing.mdanddocs/book/validation/ubuntu-vs-macos.md: "six" andK/6become "seven" andK/7.The job name and
--shardreadstrategy.job-total, and the required checks name onlyTest / ResultandLint, so no ruleset changes.Checks
test_ci_test_shards.pyandtest_ci_runner_variables.pypass: 126 tests.--shard K/7for K = 1 to 7, the same files select 19, 23, 16, 15, 13, 22 and 18 tests, which sum to 126, and all pass.axiom: n/a: CI configuration only
🤖 Generated with Claude Code