Repository navigation
Add PropertyBitmaps: bisc and auto_bisc keep their input as bitmaps, or as indices where few are good #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ulfarsson
wants to merge
38
commits into
develop
Choose a base branch
from
bisc-labelled-perms
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
348a27c
Add LabelledPerms: auto_bisc input with labels kept as bitmaps
ulfarsson de4fa24
Test auto_bisc's growth past the labelled lengths with LabelledPerms
ulfarsson b207768
Export LabelledPerms from permuta.bisc and document it in the README
ulfarsson f449beb
Define LabelledPerms' bit order by Perm.unrank
ulfarsson 9332c71
Name LabelledPerms' variables by what they hold
ulfarsson 0099214
Make LabelledPerms and its tests easier to read
ulfarsson 38c9dfa
Reject malformed bitmaps in LabelledPerms
ulfarsson 58e57db
Test the labels option and LabelledPerms given a property and bitmaps
ulfarsson a5268a9
bisc labels what a LabelledPerms lacks, and labels="bitmaps" needs a …
ulfarsson a8b80bf
Test how bisc treats a LabelledPerms, and label up to max(m, n)
ulfarsson 69057c8
Correct the memory figures in the docs
ulfarsson c54c542
Docstrings, messages and edge-case tests for LabelledPerms
ulfarsson 7ade65a
Rename LabelledPerms to PropertyBitmaps
ulfarsson 1769c1b
Plainer code where Henning stopped in PropertyBitmaps.__init__
ulfarsson 6584339
Make the views a Mapping of Collections
ulfarsson 1c8f7ac
Type bisc.py and let mypy check it
ulfarsson ea42763
Name the bit operations
ulfarsson 80b9f04
Turn every input of bisc and auto_bisc into a PropertyBitmaps
ulfarsson 84df804
Read a length with few wanted permutations by unranking them
ulfarsson 67f16bb
Test how bisc and auto_bisc take each kind of input
ulfarsson c6dcbdf
Correct what the texts say a tuple and a property do
ulfarsson 925c4a9
Stop auto_bisc when a tuple's bad permutations stop short
ulfarsson 0d437fa
Let in take any sequence that is a permutation of the length
ulfarsson b4b27e3
Readability points from the review of round 4
ulfarsson 41e9bc0
Keep a length with few good permutations as the indices of those
ulfarsson 841c8dc
Test both forms in which a length's labels are kept
ulfarsson dd7b00f
Keep the indices of a length past 20 in a list
ulfarsson de9c0d3
Label a length in add_length with a bit per good permutation once its…
ulfarsson 847e1c6
Keep a dense length's bitmap as bytes, so that reading it copies nothing
ulfarsson e69810d
Test the gaps the review of round 6 found in the two forms' tests
ulfarsson 9ac4e3d
Readability and repetition points from the review of round 6
ulfarsson b746f89
Iterate a view through one small generator for each form
ulfarsson 04e66c0
Tell the two forms apart in the tests by each length's container
ulfarsson a3c966e
Refuse a listed sequence that is not a permutation by its values
ulfarsson b14d825
Count a view's permutations without len(), so that past length 20 the…
ulfarsson b64af63
Test the gaps the review of round 7 found in the two forms' tests
ulfarsson 7da301c
Readability points from the review of round 7
ulfarsson 496d536
Keep the README's BiSC paragraph short
ulfarsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.