Repository navigation
Conversation
When an item has unlinked sockets holding the same gems, ImportSocketedItems matched each link group against the socket groups already in the build, including those it had just added for the same item. Every group after the first was treated as a reimport of that group, so three unlinked Raise Spectre became one socket group. A socket group matched or added for the current item is no longer a candidate, so each link group keeps its own socket group, on a fresh import and when reimporting without deleting skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When an imported item has unlinked sockets holding the same gems, a single socket group is created for all of them. For example, a wand with Raise Spectre in each of its three unlinked sockets is imported as one Raise Spectre group, so two of the three spectres are missing from the build.
ImportSocketedItemscompares each group of linked sockets on the item with the socket groups already in the build, so that a reimport without "Delete skills" refreshes an existing group instead of adding a copy. The socket groups already added for the same item were compared too: every unlinked socket after the first matched the first socket's group, so it only refreshed that group's gem levels and quality instead of adding a group.A socket group that was matched or added for the current item can no longer be matched, so each group of linked sockets gets its own socket group. This applies to a fresh import and to a reimport with or without "Delete skills". A build that was imported with one merged group gets the missing groups back on a reimport without "Delete skills", and the existing group is kept as it was, apart from its gem levels and quality.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: