Skip to content

Fix Node Power giving nodes another node's score #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juddisjudd wants to merge 2 commits into
base: dev
Choose a base branch
from
+20 −6
Open

Fix Node Power giving nodes another node's score #10377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a88cf
Fix Node Power giving nodes another node's score
juddisjudd Oct 4, 2026
ec82794
Include tattoos in the Node Power cache key
juddisjudd Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/Classes/CalcsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,18 @@ function CalcsTabClass:BuildPower()
end
end

-- Nodes with the same modKey can still calculate differently: radius jewels only apply to the nodes in their radius,
-- and tattoos are counted by type and boosted by jewels such as Warrior's Tale
local function powerCacheKey(env, node)
local key = node.modKey .. "|" .. node.type .. (node.isTattoo and "|" .. tostring(node.overrideType) or "")
for index, rad in ipairs(env.radiusJewelList) do
if rad.nodes[node.id] then
key = key .. "|" .. index
end
end
return key
end

-- Estimate the offensive and defensive power of all unallocated nodes
function CalcsTabClass:PowerBuilder()
-- local timer_start = GetTime()
Expand Down Expand Up @@ -610,10 +622,11 @@ function CalcsTabClass:PowerBuilder()
end
for nodeId, node in pairs(nodes) do
if not node.alloc and node.modKey ~= "" and not self.mainEnv.grantedPassives[nodeId] then
if not cache[node.modKey] then
cache[node.modKey] = calcFunc({ addNodes = { [node] = true } }, useFullDPS)
local key = powerCacheKey(self.mainEnv, node)
if not cache[key] then
cache[key] = calcFunc({ addNodes = { [node] = true } }, useFullDPS)
end
local output = cache[node.modKey]
local output = cache[key]
calculateAddNodePower(node.power, distance, node, output, function()
local pathNodes = { }
for _, pathNode in pairs(node.path) do
Expand All @@ -622,10 +635,11 @@ function CalcsTabClass:PowerBuilder()
return pathNodes
end)
elseif node.alloc and node.modKey ~= "" and not self.mainEnv.grantedPassives[nodeId] then
if not cache[node.modKey.."_remove"] then
cache[node.modKey.."_remove"] = calcFunc({ removeNodes = { [node] = true } }, useFullDPS)
local key = powerCacheKey(self.mainEnv, node).."_remove"
if not cache[key] then
cache[key] = calcFunc({ removeNodes = { [node] = true } }, useFullDPS)
end
local output = cache[node.modKey.."_remove"]
local output = cache[key]
if self.powerStat and self.powerStat.stat and not self.powerStat.ignoreForNodes then
node.power.singleStat = self:CalculatePowerStat(self.powerStat, output, calcBase)
if node.depends and not node.ascendancyName then
Expand Down