Repository navigation
Conversation
Member
There was a problem hiding this comment.
But not all drifters record salinity, right? This is only for a small subset of the drifters. So make clear it's optional?
| | **ARGO_FLOAT** | TEMPERATURE | Sea Water Potential Temperature | °C | Physical | | ||
| | | SALINITY | Sea Water Salinity | psu | Physical | | ||
| | **DRIFTER** | TEMPERATURE | Sea Water Potential Temperature | °C | Physical | | ||
| | | SALINITY | Sea Water Salinity | psu | Physical | |
Member
There was a problem hiding this comment.
Hmm, we might need to consider the units here. psu is old and deprecated - the "correct" uint is g/kg (or unites) now. But what does copernicusmarine provide?
| description=("Sensors fitted to the drifter. Supported: TEMPERATURE. "), | ||
| default_factory=lambda: [ | ||
| SensorConfig(sensor_type=SensorType.TEMPERATURE), | ||
| SensorConfig(sensor_type=SensorType.SALINITY), |
Member
There was a problem hiding this comment.
So salinity sampling is default always on for drifters? Do we really want that? is that authentic?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds salinity as a measurement to the Drifter instrument, which is a requested feature (see #312 ).
Closes #312