Repository navigation
Correct waypoint numbers are shown in Schedule.verify() error messages - #403
Merged
Merged
Conversation
…g non-active Ports); add another test param to ensure getting the correct waypoint
…points are named in the out-of-order waypoint times error
erikvansebille
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the
Schedule.verify()checks ('waypoint would be reached too late' and 'waypoints are not in order') could show the wrong waypoint number in their error messages. For the 'too late' check, this only happened when the departure port was empty/not-in-use. In that case, the numbering was displaced by 1, so the error named the waypoint before the one actually at fault. The 'not in order' check was wrong in all cases, because it listed the waypoints that were correctly ordered (and showed ports as#None).This PR fixes both so that the correct waypoint is named. The tests now include a configuration with an inactive departure port, and check the exact waypoint named in the 'not in order' error.