Repository navigation
SCHISM tutorial update - #2941
Open
fluidnumericsJoe wants to merge 1 commit into
Open
fluidnumericsJoe wants to merge 1 commit into
fluidnumericsJoe wants to merge 1 commit into
Conversation
Member
There was a problem hiding this comment.
In the tilmestep comment, should we also suggest that users could experiment with adaptive time stepping in e.g. AdvectionRk45? Have you tried that already for unstructured grids? Does it work (well)?
Contributor
Author
There was a problem hiding this comment.
I have not tried this yet, but will check it out. I'm playing with a CFL guided time step reduction per particle and will compare with RK45
Member
There was a problem hiding this comment.
Also, the figures don't load well in RTD? https://parcels--2941.org.readthedocs.build/en/2941/user_guide/examples/tutorial_schism.html. Can you check what's going on?
Contributor
Author
There was a problem hiding this comment.
I must've not committed them. oops. I'll get that sorted
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following up from #2928 , this PR adds a section on things to consider when adapting the SCHISM tutorial to other use cases. This covers time step size / CFL, interpolator choice, and handling grid search errors. Links to other internal parcels documentation are included for each consideration.