Skip to content

Testing nikshay - #159

Merged
chetansaroya merged 12 commits into
PSMRI:release-3.13.0from
chetansaroya:testing-nikshay
Nov 4, 2026
Merged

chetansaroya merged 12 commits into
PSMRI:release-3.13.0from
chetansaroya:testing-nikshay

Conversation

@chetansaroya

Copy link
Copy Markdown
Contributor

📋 Description

JIRA ID: STOP-647

  • ✨ New feature (non-breaking change which adds functionality)

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 20b194f5-9229-42d3-bcba-07933b963e8d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

*/
public List<NikshayIdGenerateBeneficiaryDTO> findAllNegativeBeneficiaries() {
JdbcTemplate jdbcTemplate = new JdbcTemplate(dataSource);
return jdbcTemplate.query(ALL_NEGATIVE_BENEFICIARIES_SQL, (rs, rowNum) -> mapRow(rs));
+ "ORDER BY b.updated_at DESC, b.ben_reg_id DESC LIMIT :size OFFSET :offset";
params.addValue("size", size);
params.addValue("offset", page * size);
return new NamedParameterJdbcTemplate(dataSource).queryForList(sql, params);
MapSqlParameterSource params = new MapSqlParameterSource();
String sql = "SELECT COUNT(*) "
+ filteredBeneficiariesSql(phase, status, failedOnly, failureReason, beneficiaryType, search, params);
Long count = new NamedParameterJdbcTemplate(dataSource).queryForObject(sql, params, Long.class);
@PankajUnthin

Copy link
Copy Markdown

@coderabbitai Please review.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

@PankajUnthin I will review the changes in this PR.

Action not completed

Review skipped: 107 files exceed the limit of 100.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@drtechie

drtechie commented Nov 2, 2026

Copy link
Copy Markdown
Member

@CodeRabbit full review

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Action not completed

Review skipped: 107 files exceed the limit of 100.

Comment thread nikshay-enroll/package.json Outdated

@drtechie drtechie Nov 2, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work?
There is a playwright repo inside a java repo?

@@ -0,0 +1,55 @@
/*
* AMRIT – Accessible Medical Records via Integrated Technology

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMRIT – Accessible Medical Records via Integrated Technology
Make this Technologies please.
Across the PR.

Comment thread nikshay-enroll/lib/auth.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetansaroya is this really needed? Can't we send login requests directly from Java?

@chetansaroya
chetansaroya changed the base branch from Nikshay-Testing to release-3.13.0 November 3, 2026 09:38
@chetansaroya

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Action not completed

Review skipped: 107 files exceed the limit of 100.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chetansaroya

Copy link
Copy Markdown
Contributor Author

Addressed JS call for login with Java.

@drtechie

drtechie commented Nov 3, 2026

Copy link
Copy Markdown
Member

@chetansaroya LGTM. There are some open security issues.

@chetansaroya
chetansaroya requested a review from drtechie November 4, 2026 05:53
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@chetansaroya
chetansaroya merged commit 1115e59 into PSMRI:release-3.13.0 Nov 4, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants