Repository navigation
refactor: read Excel with openpyxl and drop pandas - #57
Merged
Merged
Conversation
- ExcelImporter reads .xlsx with openpyxl; pandas and pandas-stubs are gone (review M3). - Column detection shared with the PDF importer (whole words), which fixes the same substring bug in the Excel import. - .xls is no longer offered: it never worked without xlrd.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review item M3.
ExcelImporterreads.xlsxwithopenpyxl(already a dependency) instead ofpandas.pandasandpandas-stubsleave the requirements: smaller install and Docker image.app/services/importer/columns.pyand is shared with the PDF importer. The Excel import had the same substring bug fixed for PDF in fix: PDF import header matching; dependency and import cleanup #55 ("Login method" taken as the entry column); now both match whole words..xlsis no longer accepted:pandasneededxlrdto read it, which was never installed, so those uploads always failed. The settings text and the Spanish catalog sayxlsxonly.Tests: the Excel tests build workbooks with
openpyxl; new tests for time cells, whole-word headers and.xlsrejected. Also checked end to end throughPOST /import/with a real.xlsx(date and time cells) and a.xls.