Skip to content

🎉 feat(paraview): add Sample JSON and directory readers for individual Samples - #519

Open
fbordeu wants to merge 2 commits into
mainfrom
ParaViewSample_reader
Open

fbordeu wants to merge 2 commits into
mainfrom
ParaViewSample_reader

Conversation

@fbordeu

@fbordeu fbordeu commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

…l Samples

Thanks for contributing! Please make sure your PR title and content follow the guidelines.
Leave this checklist below in your PR description and tick the corresponding boxes.

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

✅ PR Title Format

Your PR title must start with one of the following emojis to indicate the type of change:

  • 🐛 Bug fix
  • 📄 Documentation
  • 🎉 New feature or initial commit
  • 🚀 Performance or deployment
  • ♻️ Refactor or cleanup
  • 📦 Packaging or dependency management (e.g., pyproject.toml, conda, Poetry, pre-commit)

Example:
🎉 Add MMD-based split method


📋 Description (optional)

Please explain what your PR does:

  • What problem does it solve?
  • Any breaking changes?
  • How was it tested?

🔗 Related issues (optional)

Closes #___

@fbordeu
fbordeu requested a review from a team as a code owner October 27, 2026 05:00
@fbordeu fbordeu changed the title 🎉 feat(paraview): add Sample JSON and directory readers for individua… 🎉 feat(paraview): add Sample JSON and directory readers for individual Samples Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fbordeu
fbordeu force-pushed the ParaViewSample_reader branch from 18102d9 to aaa4ba8 Compare October 29, 2026 04:05
@fbordeu

fbordeu commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator Author

i added a simple non plaid dependent SampleReader to ParaView, this reader can read independent sample stored in CGNS with Globals and time dependent data.

Comment thread CHANGELOG.md
### Added

- (ParaView plugin) add an experimental `PlaidSampleVTKReader` for standalone CGNS Sample-directory reading with physical timesteps, using VTK without PLAID. Keep the existing Sample reader unchanged; document native VTK hierarchy differences and CGNS compatibility limitations. And expose a second, time-synchronized Globals table output using h5py.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line in changelog ;-)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants