Repository navigation
Show an Active chip on Home - #7
Closed
HugoHeneault wants to merge 1 commit into
Closed
HugoHeneault wants to merge 1 commit into
HugoHeneault wants to merge 1 commit into
Conversation
The live scope already existed and was only missing from the strip. It is labelled Active and carries a count like All and Archived.
Author
|
Opened against spatie/bloom instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home's strip shows
AllandArchived, so the only way to see what can still be acted on is to scroll past the archive.The
livescope already existed (!row.isArchived) and was only missing from the strip. It is back between the two, labelled "Active", with a count like its neighbours (All 9,Active 1,Archived 8). Needs you and Running stay off the strip.Tests:
HomeScopeTestsupdated for the three chips, the label and the badge. Not run locally;swift build -Xswiftc -warnings-as-errors,make lintandmake swiftlintare green, and I checked the chip by hand in Bloom Dev.