Repository navigation
Implement resource reloader dependency system - #96
Open
SpaceWalkerRS wants to merge 3 commits into
Open
SpaceWalkerRS wants to merge 3 commits into
SpaceWalkerRS wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new API to register identifiable
ResourceReloaders and a way to declare dependencies between them. This ensures a certain ordering between reloaders which was not possible to do before. The old API for adding reloaders still exists but is deprecated. Any reloaders added through this API will be run last.New API
ReloadableResourceManagerhas news method for registering identifiable resource reloaders and dependencies between them:OSL will ensure all Vanilla reload listeners are registered as identifiable reloaders. The identifiers used are public API in the
AssetsReloadersandDataReloadersclasses. These classes also listbefore_vanillaandafter_vanillamarkers that can be used to ensure your reloaders run before or after all Vanilla reload listeners.Example Usage