Repository navigation
Resource Loader startup improvements - #94
Open
SpaceWalkerRS wants to merge 2 commits into
Open
SpaceWalkerRS wants to merge 2 commits into
SpaceWalkerRS wants to merge 2 commits into
Conversation
texturepacks in early alpha improve startup
SpaceWalkerRS
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in versions before 1.6 Resource Loader would run two full resource reloads on start-up. This PR refactors some of the implementation details to stop that from happening, and adds a more convenient way to initiate a resource reload.
I also removed the Mixin plugin in favor of using Conditional Mixin, so it is possible there is a regression if I messed that up, though from testing it seems to work fine.
API Changes
reloadResourcesmethod toMinecraftin 1.5.2 and below, with the same functionality as in 1.6+. It reloads the pack repository, starts a full resource reload, and reloads the world renderer.