Repository navigation
Google Ads v26.1 - #142
Google Ads v26.1#142Lewis-Clayton wants to merge 7 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 836a32be91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "dependencies": { | ||
| "google-gax": "^6.3.0" | ||
| "google-gax": "^6.16.0" |
There was a problem hiding this comment.
After this dependency is raised to ^6.16.0, the committed package-lock.json still declares ^6.3.0 at the root and resolves node_modules/google-gax to 6.3.0. Consequently, clean workflows using npm ci cannot reproduce/install the declared dependency set, blocking a fresh build or release from this lockfile; regenerate and commit the root npm lockfile alongside this change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 0a060ad: the root package-lock.json now declares and locks google-gax 6.16.0, and both root lockfiles move @grpc/grpc-js to 1.14.7.
Summary
betadist-tagTest plan
yarn testpasses on Node 22.23 and 24sedrequest-parameter check prints nothing26.1.0-beta.0under thebetadist-tag and consume it from google-ads-api26.1.0under thelatestdist-tag