Skip to content

identifyAndTokenize: forward nonOverridingMatchers to the cache merge - #371

Open
etiennelatendresse-optable wants to merge 1 commit into
masterfrom
tokenize-non-overriding-matchers
Open

etiennelatendresse-optable wants to merge 1 commit into
masterfrom
tokenize-non-overriding-matchers

Conversation

@etiennelatendresse-optable

@etiennelatendresse-optable etiennelatendresse-optable commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Why

mergeCache has taken nonOverridingMatchers since #362, but identifyAndTokenize from #342 forwarded only maxUidsPerEid, so the tokenize merge could not apply the rule. That merge is the one place it matters, because tokenize is what returns the first-party EIDs that would otherwise evict third-party ones.

What changed

  • identifyAndTokenize accepts nonOverridingMatchers and passes it to the cache merge.
  • A first-party EID returned by tokenize no longer replaces a third-party EID already cached on the same source, when its matcher is in the list.
  • Omitting the option leaves the merge exactly as before.
  • The README lists the three options that control the cache write: cacheKey, maxUidsPerEid and nonOverridingMatchers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant