Repository navigation
analytics: stop dropping Optable EIDs in the V2 source dedupe - #366
Merged
Merged
Conversation
The dedupe kept the last EID per source, so a later non-Optable EID with the same source hid an Optable one and optableSources, optableMatchers and optableTargetingDone under-reported. The dedupe only fed the Optable filter, whose outputs are already distinct, so filter the full EID list like V1.
mosherBT
force-pushed
the
mo/analytics-v2-optable-eid-dedupe
branch
from
October 15, 2026 01:01
2fea96b to
ad7cfd0
Compare
mosherBT
marked this pull request as ready for review
October 15, 2026 01:02
Dropping the dedupe broke its intended job of collapsing the same Optable EID copied into both user.ext.eids and user.eids. Keying on source and inserter keeps that while stopping another inserter's same-source EID from hiding Optable's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
V2 dedupes EIDs by
source, keeping the last one, before picking out Optable's. A later non-Optable EID with the samesource(e.g. LiveIntent'suidapi.com) hides the Optable one, sooptableSources,optableMatchersandoptableTargetingDoneunder-report. V1 doesn't dedupe and doesn't have the gap. Raised by @etiennelatendresse-optable on #364.What Changed
toWitness: dedupe EIDs bysource+inserterinstead ofsourcealone. The same Optable EID copied intouser.ext.eidsanduser.eidsstill collapses to one, but another inserter's same-source EID no longer hides Optable's.How to Test
toWitnesscase: Optable EID followed by a non-Optable EID with the samesourceNotes