Repository navigation
Conversation
antoinehakim-optable
approved these changes
Oct 9, 2026
mosherBT
force-pushed
the
mo/analytics-v2-totalbids-adunitcode
branch
from
October 15, 2026 18:13
1442ac6 to
1201235
Compare
etiennelatendresse-optable
approved these changes
Oct 19, 2026
…id analytics V2 declared both but never set them, so every payload sent adUnitCode "unknown" and no totalBids. Match V1: the first bid's ad unit, and a count of received bids with a cpm.
mosherBT
force-pushed
the
mo/analytics-v2-totalbids-adunitcode
branch
from
October 19, 2026 16:09
9626e2a to
bb86c40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
V2 (
lib/addons/prebid/analytics.ts) declarestotalBidsandadUnitCodebut never sets them: every payload sendsadUnitCode: "unknown"and nototalBids. V1 reports both. Parity gaps blocking the V1/V2 merge.What Changed
toWitness:totalBidscounts received bids with a non-nullcpm, and is added to the payload.toWitness: top-leveladUnitCodeis the first bid's ad unit,"unknown"when there are no bids.How to Test
toWitnesscases: zero, one and several received bids across bidder requests; populated and fallbackadUnitCodeNotes