Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconnect storms can leave authentication work queued after controllers disconnect or hit their deadline. This change bounds running lookups and waiting jobs, removes abandoned waiters before SQL, and rejects duplicates before querying while preserving the existing owner and final ownership check.
It also caps incoming WebSocket messages at 4 MiB before authentication, enforces MySQL pool/deadline limits, and adds bounded aggregate telemetry independent of sampled logs. Existing firmware remains supported; heartbeat changes, caching, owner probing and pre-upgrade admission are deferred.
This PR is stacked on #7 (
fix/connection-lifecycle-hardening) and contains four implementation commits plus a regression-test commit. The MySQL changes depend on the authentication context interface; coordinated reverts may be necessary.Validation:
No production rollout is included. The missing hard socket-admission/output-buffer bounds remain explicit follow-up scope.