Repository navigation
Conversation
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 5, 2026 15:56
f257778 to
621e42c
Compare
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 6, 2026 14:55
621e42c to
b32942b
Compare
karhu
commented
Nov 6, 2026
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 6, 2026 15:25
b32942b to
312a676
Compare
karhu
marked this pull request as ready for review
November 6, 2026 15:25
RealLast
requested changes
Nov 8, 2026
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 9, 2026 09:36
312a676 to
9a145a6
Compare
✅ CI checks passed
Updated for |
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 9, 2026 10:22
9a145a6 to
435ccfb
Compare
Contributor
Author
|
@RealLast Same here, addressed your feedback. Please take another look! |
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
4 times, most recently
from
November 9, 2026 19:32
ee13fef to
ce5fae6
Compare
RealLast
approved these changes
Nov 10, 2026
RealLast
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Minor nits for clean up
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 10, 2026 16:46
ce5fae6 to
a1c4841
Compare
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 10, 2026 18:58
a1c4841 to
f84ad22
Compare
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 10, 2026 19:20
f84ad22 to
4bf1974
Compare
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 10, 2026 19:36
4bf1974 to
53ff091
Compare
A remote or S3 registry now accepts only a release that was built from committed TimeNet code. Each manifest records the git commit of the TimeNet packages and whether they had local changes. If a manifest records local changes, put_release() raises TimeNetBuildError. The same applies to put_dataset(), because it publishes through put_release(). copy_release(), and so timenet.publish() and timenet-build --publish-to, checks every release that it copies before it copies anything. The check reads the manifest, not the installed code, because a publish copies a release that was built earlier. LocalRegistry accepts any release, through the new requires_committed_code property. Part of TNET-165
karhu
force-pushed
the
feature/refuse-untraceable-publish
branch
from
November 10, 2026 19:54
53ff091 to
f74087e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release in a remote registry outlives the machine that built it, so its manifest must name the exact code. A remote or S3 registry now accepts only a release whose manifest records TimeNet code without local changes. A local registry accepts any release. There is no override.
The check reads
build_env.gitin the manifest, not the installed code, because a publish copies a release that was built earlier.PackageSnapshotandTimeNetSnapshotgetrequire_no_local_changes(), andWritableRegistrygets the propertyrequires_committed_code(Falseonly forLocalRegistry) and the methodrequire_committed_code(manifest).Every way to publish checks the rule:
put_release()refuses before it uploads anything.put_dataset()publishes throughput_release(), so it refuses too.copy_release()checks every release that it copies before it copies anything, sotimenet.publish()andtimenet-build build --publish-toleave the destination unchanged.The error names the registry, the release and the package with local changes. It says to build the release again from committed code, or to keep it in a local registry. With
--publish-to, a build with local changes still lands in the local registry, and only the publish step fails.The docs describe the rule in a new section, "Committed code for remote registries".
This replaces the first design of this PR, which gated
publish_pipeline()on a snapshot of the installed code. Main removedpublish_pipeline(): a build now always lands in the local registry, and a publish is a separate copy.Closes TNET-165
Stack created with GitHub Stacks CLI • Give Feedback 💬