Repository navigation
test(sponsors): make sponsor material types deterministic in fixture - #628
Merged
Merged
Conversation
Random types left ~1.7% of sponsors with no Video material, making testGetAllSponsorsMaterialsBySponsorAndType flaky in CI.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-628/ This page is automatically updated on each push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InsertSummitTestDataassigned each of a sponsor's 10 materials a random type (Link/Video/Slide). With probability (2/3)^10 ≈ 1.7% a sponsor gets noVideo, soOAuth2SummitSponsorApiTest::testGetAllSponsorsMaterialsBySponsorAndType(filter=type==Video) fails with an emptydataarray (seen in the OAuth2Tests job of run 37985993376).The type is now
ValidTypes[$j % count(ValidTypes)], so every sponsor always has Video materials.Tests
vendor/bin/phpunit tests/oauth2/OAuth2SummitSponsorApiTest.php --filter Material→ OK (6 tests, 30 assertions).