Repository navigation
Conversation
…nt page For native clients registered with a custom URI scheme, tapping the app title or the tooltip link navigated the auth browser to the callback without an authorization code and killed the login. The app title now links to the client website (http/https only, new tab) when configured, otherwise it is plain text. The redirect URL is shown as plain text in the tooltip. website is exposed to the view config via @JSON.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-167/ This page is automatically updated on each push to this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86bcd4ahx
Problem
The consent page rendered the app name and a tooltip entry as anchors with
href= the client'sredirect_uri. For native clients (custom URI scheme, e.g.com.fntech.ftnattendee://callback) tapping either link navigated to the callback without a code and killed the login.Changes
website(new tab,rel=noopener noreferrer) only when it is http(s); otherwise plain text.redirectURLas plain text.websiteexposed inconsent.blade.phpconfig via@json(owner-controlled value, avoids JS injection).consent_components.jswith unit tests (Jest,renderToStaticMarkup).Notes
{!! !!}interpolations inconsent.blade.phpare unchanged (out of scope, tech debt).Testing
public/assets).