Skip to content

fix(pdf): rethrow download errors and check pre-baked font families - #356

Open
gcutrini wants to merge 2 commits into
v4.xfrom
fix/pdf-toolkit-v4.x
Open

gcutrini wants to merge 2 commits into
v4.xfrom
fix/pdf-toolkit-v4.x

Conversation

@gcutrini

@gcutrini gcutrini commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

ref: https://app.clickup.com/t/86bbf0d90

The same two fixes as #318 (0f47091 and 38a3a7a), for the toolkit #317 added to v4.x:

  • downloadBlob only logged a failed download, so createDocument().download() resolved and onError never ran. It rethrows the error after logging it.
  • resolveFont registered a pre-baked container even when its fonts did not define the family, and pdfmake failed later while building the file. Such a container falls back to Helvetica, like a font URL that fails to load.

downloadBlob only logged a failed download, so
createDocument().download() resolved and onError never ran.
downloadBlob rethrows the error after logging it.
resolveFont registered a pre-baked container even when its fonts did
not define the family, and pdfmake failed later while building the
file. Such a container falls back to Helvetica, like a font URL that
fails to load.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 362513d0-a92c-4f91-8fc9-e0c1f2ebd945

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant