Repository navigation
Split the model factories into a domain spec and a thin create_model - #26
Draft
hmgaudecker wants to merge 2 commits into
Draft
hmgaudecker wants to merge 2 commits into
hmgaudecker wants to merge 2 commits into
Conversation
`build_model_spec` returns the domain keyword arguments of `lcm.Model` for the baseline (`policy=None`) or an ACA policy, including the entry initial nodes and derived categoricals, and reads only `pia_aime_grid` from the parameters. `create_model(spec=, fixed_params=, **model_options)` forwards generic options unchanged; without `execution_config` pylcm's device default applies. The ACA factory module is gone and the benchmark forwards `**model_options`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hs8mfXPYyEa24KaAp6BwCW
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hs8mfXPYyEa24KaAp6BwCW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
build_model_spec(...)returns the model's domain as keyword arguments forlcm.Model:initial_nodes;policy=Nonebuilds the baseline, and aPolicyVariantapplies its ACA overlay. The ACA factory module is removed.pia_aime_gridinstead offixed_params.pia_aime_gridis the only parameter that grid construction reads.build_grids,build_all_regimesandbuild_model_slotstake it the same way.create_model(spec=..., fixed_params=..., **model_options)forwards every otherlcm.Modeloption unchanged. An option the spec also holds, such asinitial_nodes, overrides the spec's value.create_modeldoes not trim or rewrite the params.execution_config, pylcm's"device"budget applies. That budget needs a preallocated allocator pool, which every Marvin batch job already has through the workspaceslurm_env.create_benchmark_model(*, pref_type_grid, grid_config, final_age, **model_options)builds through the same spec.durable_identity) and aninitial_nodesoverride all reachModelunchanged.https://claude.ai/code/session_01Hs8mfXPYyEa24KaAp6BwCW