Skip to content

feat(drivers/onedrive|drivers/onedrive_app): support permanent deleti… - #3185

Open
Dainsleif233 wants to merge 1 commit into
OpenListTeam:mainfrom
Dainsleif233:feat/onedrive-delete-permanently
Open

Dainsleif233 wants to merge 1 commit into
OpenListTeam:mainfrom
Dainsleif233:feat/onedrive-delete-permanently

Conversation

@Dainsleif233

Copy link
Copy Markdown

…on (close #3172)

  • Add a remove_way select with trash and delete to the Onedrive and OnedriveAPP drivers
  • Call the Graph permanentDelete action when remove_way is delete; trash and unset values keep moving items to the recycle bin
  • Resolve the drive and item ids the action requires from the listed object, falling back to a metadata lookup and the drive itself
  • Cover the recycle bin and permanent delete paths with tests in both drivers

Summary / 摘要

Adds a Remove way (remove_way) select to the OneDrive and OneDrive APP drivers:

  • Trash — default, and what an unset value means: plain Graph delete, the item goes to the OneDrive recycle bin.
  • Delete — posts to the Graph permanentDelete action: neither recycle bin stage is used and the space is released immediately.

permanentDelete is item-id scoped, so the item id comes from the listed object (falling back to a metadata lookup) and the drive id from its parentReference (falling back to the drive itself). Existing storages keep the old behavior. Same option as the Aliyun Drive Open driver; no new Graph permission is needed.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend: not needed — src/lang/en/drivers.json is regenerated from this repository by the frontend's Sync i18n files workflow (chore: auto update i18n file).
  • OpenList-Docs: {Docs PR 链接}

Related Issues / 关联 Issue

Closes #3172

Testing / 测试

  • go test ./drivers/onedrive/ ./drivers/onedrive_app/ -count=1 — 6 tests each: unset/trash → plain DELETE, delete → permanentDelete, ids resolved from the path, Graph errors propagated.
  • go build ./..., go vet, gofmt — clean.
  • go test ./... — run; the two changed packages pass, every other failure reproduces identically on unmodified main (482464c) (e.g. lanzou / offline_download/115* fail to build under Go 1.27).
  • Manual test / 手动测试.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING。
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmt、go fmt 或 prettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明): DeepSeek (DeepSeek Harness coding agent)

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution (Co-authored-by: DeepSeek <148330874+deepseek-ai@users.noreply.github.com>).
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

…on (close OpenListTeam#3172)

- Add a `remove_way` select with `trash` and `delete` to the Onedrive and OnedriveAPP drivers
- Call the Graph `permanentDelete` action when `remove_way` is `delete`; `trash` and unset values keep moving items to the recycle bin
- Resolve the drive and item ids the action requires from the listed object, falling back to a metadata lookup and the drive itself
- Cover the recycle bin and permanent delete paths with tests in both drivers

Co-authored-by: DeepSeek <148330874+deepseek-ai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Onedrive支持删除文件不进入回收站

1 participant