Skip to content

Add anonymous impact status to superuser UI - #5263

Merged
taylordowns2000 merged 5 commits into
mainfrom
impact-reporting-status
Oct 29, 2026
Merged

taylordowns2000 merged 5 commits into
mainfrom
impact-reporting-status

Conversation

@taylordowns2000

@taylordowns2000 taylordowns2000 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Closes #5262 by adding a card to the "Maintenance" screen.

image image

Validation steps

Check for three different "looks" by changing your ENV:

  1. Enabled, hashed UUID only (the default)
USAGE_TRACKING_ENABLED=true
USAGE_TRACKER_HOST=http://localhost:9999

You'll see a green "Enabled" badge, "Reporting to" with your host, and "Only the hashed UUID is sent…".

  1. Enabled, cleartext UUID
USAGE_TRACKING_ENABLED=true
USAGE_TRACKING_UUIDS=cleartext
USAGE_TRACKER_HOST=http://localhost:9999

The identity line changes to "The instance UUID is sent in cleartext (and hashed)…".

  1. Disabled (the strong-language callout)
USAGE_TRACKING_ENABLED=false

You'll see a red "Disabled" badge, the red "Please turn anonymous usage metrics back on" callout, and "Would report to" in place of "Reporting to". Adding USAGE_TRACKING_UUIDS=cleartext here also changes the identity line, so there are four combinations in total.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation Bot moved this to New Issues in Core Oct 28, 2026
@taylordowns2000 taylordowns2000 changed the title close #5262 Add anonymous impact status to superuser UI Oct 28, 2026
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — the new query reads instance-level DailyReportConfiguration and Lightning.Config values, not project-scoped resources.
  • S1 (authorization): New usage_tracking_status/0 is only called inside the existing superuser? gate in mount/3 (lib/lightning_web/live/maintenance_live/index.ex:20), matching the admin-space policy already enforced for this LiveView.
  • S2 (audit trail): N/A — the change is read-only display; no inserts/updates/deletes to configuration are introduced.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.5%. Comparing base (0dbe0ec) to head (4aef032).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5263   +/-   ##
=====================================
  Coverage   91.5%   91.5%           
=====================================
  Files        466     467    +1     
  Lines      23841   23852   +11     
=====================================
+ Hits       21816   21831   +15     
+ Misses      2025    2021    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mwambuka Mwambuka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, Taylor!

@taylordowns2000
taylordowns2000 merged commit 274f225 into main Oct 29, 2026
8 checks passed
@taylordowns2000
taylordowns2000 deleted the impact-reporting-status branch October 29, 2026 04:51
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Anonymous metrics UI enhancement

2 participants