Conversation
andrew-platt
approved these changes
Sep 29, 2026
…e--OLAF.dat. Also updated r-test pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged
Feature or improvement description
This PR only changes the default
RegFunctionPartsetting in OLAF from1(exponential regularization) to2(compact regularization). The latter enables significant speed up.Only one line of code is changed. All other changes are either documentation or comments.
Related issue, if one exists
PR #3457, PR #3464
Impacted areas of the software
OLAF, docs, r-test (comment only)
Test results, if applicable
All existing OLAF r-tests specify
RegFunctionPartdirectly without using thedefaultkeyword, so there is no change to r-test results. However, r-test merging is still required due to the updated comments.