Repository navigation
[PATCH v6] api: packet: deprecate packet vectors - #2406
Merged
MatiasElo merged 8 commits intoOct 23, 2026
Merged
Conversation
github-actions
Bot
changed the title
MatiasElo
reviewed
Oct 7, 2026
TuomasTaipale
force-pushed
the
dev/packet_vec_depr
branch
from
October 9, 2026 08:45
9abd995 to
ecdc011
Compare
github-actions
Bot
changed the title
Contributor
|
Acked-by: Pavan Nikhilesh Bhagavatula pbhagavatula@marvell.com |
MatiasElo
approved these changes
Oct 16, 2026
MatiasElo
added
the
API spec OK
github-actions
Bot
changed the title
MatiasElo
reviewed
Oct 22, 2026
Comment on lines
+4768
to
+4769
| if (recv && !aggr_capa.source.bit.pktin) | ||
| return ODP_TEST_INACTIVE; |
Collaborator
There was a problem hiding this comment.
Since aggr_capa.source.bit.pktin is basically only a hint for the application and it looks like the test should pass also if only normal packets are received, it's perhaps better to not disable this.
TuomasTaipale
force-pushed
the
dev/packet_vec_depr
branch
from
October 22, 2026 07:39
ddc0540 to
9b836a3
Compare
github-actions
Bot
changed the title
TuomasTaipale
force-pushed
the
dev/packet_vec_depr
branch
from
October 22, 2026 12:49
9b836a3 to
5bb2527
Compare
github-actions
Bot
changed the title
MatiasElo
added
API Ready
Deprecate packet vectors. The newer event vector API is now the main vectorization interface. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com> Acked-by: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Add new `odp_event_aggr_capability_t::source` capability for signaling ability for different event sources to generate event vectors if configured with an event aggregator queue. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com> Acked-by: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Fill the new `odp_event_aggr_capability_t::source` capability for plain and scheduled queue aggregators. Event aggregation is done in software when events are enqueued to an aggregator queue, so events from all sources can be aggregated. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Print the new `odp_event_aggr_capability_t::source` capability of plain and scheduled queue aggregators. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Packet input aggregates packets into event vectors only if the aggregator capability advertises the packet input event source. Print a warning with the `odp_event_aggr_capability_t::source` bits in event vector receive tests when the `pktin` bit is not set. This helps to identify failures caused by missing aggregation while still running the tests on implementations that do not yet report source capabilities. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Classifier aggregates packets into event vectors only if the aggregator capability advertises the classifier event source. Print a warning with the `odp_event_aggr_capability_t::source` bits in event vector tests when the `cls` bit is not set. This helps to identify failures caused by missing aggregation while still running the tests on implementations that do not yet report source capabilities. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Application enqueues to an aggregator queue are aggregated into event vectors only if the aggregator capability advertises the queue event source. Print a warning with the `odp_event_aggr_capability_t::source` bits in aggregator enqueue tests when the `queue` bit is not set. This helps to identify failures caused by missing aggregation while still running the tests on implementations that do not yet report source capabilities. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
Packet input aggregates packets into event vectors only if the aggregator capability advertises the packet input event source. Otherwise, workers receive plain packets in event vector mode. Print a warning with the `odp_event_aggr_capability_t::source` bits when the `pktin` bit is not set, but still allow event vector mode on implementations that do not yet report source capabilities. Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
MatiasElo
force-pushed
the
dev/packet_vec_depr
branch
from
October 23, 2026 14:23
5bb2527 to
2557a0a
Compare
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate packet vectors. The newer event vector API is now the main vectorization interface.
Additionally, introduce
odp_event_aggr_capability_t::sourcecapability for signaling ability for different event sources to generate event vectors if configured with an event aggregator queue. This replaces the capability structures defined for the now deprecated packet vectors.v2:
v4:
v5: