Repository navigation
fix(storage): preserve writes racing lazy flushes - #549
Closed
rikkurea-boop wants to merge 2 commits into
Closed
rikkurea-boop wants to merge 2 commits into
rikkurea-boop wants to merge 2 commits into
Conversation
Contributor
Author
rikkurea-boop
added a commit
to rikkurea-boop/DataFlow
that referenced
this pull request
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
LazyFileStorage.flush_step()from clearing the dirty state of a newer write that races with an older flush.Problem
flush_step()snapshots the current dataframe under the storage lock, persists that snapshot outside the lock, then reacquires the lock and clears the step from_dirty_steps.A concurrent
write()may replace the buffered dataframe and mark the same step dirty after the old flush has taken its snapshot but before that flush completes.The old flush would then unconditionally clear
_dirty_steps, incorrectly marking the newer generation clean even though it has not been persisted.Fix
Only clear the dirty marker when the dataframe currently stored for the step is still the same dataframe generation that was persisted by this flush.
Conceptually: