Repository navigation
Conversation
lohedges
had a problem deploying
to
somd2-build
October 22, 2026 14:50 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
somd2-build
October 22, 2026 14:50 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
somd2-build
October 22, 2026 18:36 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
somd2-build
October 22, 2026 18:36 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alchemical ions were always given their own
standard_morphschedule, so their charge changed linearly over the whole λ range. Intermediate states were only neutral if the perturbable molecule's charge also changed linearly, which isn't the case for the ABFE,charge_scaled_morphor ring-breaking schedules.Changes
annihilate/decouple: alchemical ions get a schedule with the same stages and stage weights as the ligand's. It morphs duringdechargeand holds the final state after that. This also applies when these schedules are passed as objects, e.g.decouple(fix_epsilon=False). The ligand's schedule can't be reused directly, because its ghost-atom equations, e.g. fixed epsilon, would stop the ion reaching its end state.standard_morph,charge_scaled_morph,ring_break_morph,reverse_ring_break_morph: alchemical ions follow the perturbable molecule's schedule.standard_morph, and a warning says that intermediate states are only neutral if the perturbable molecule's charge changes linearly. No warning is raised when the custom schedule isstandard_morphitself.Notes
charge_scaled_morph, the decharge and recharge stages scale the ligand's net charge, which the ion can't offset. The ion now matches the lihe morph stage.Tests
tests/schedules/test_abfe.py: the ion's charge changes at the same rate as the ligand's for both ABFE schedules, with and without `fix_epsilonhts, and its LJ parameters reach theirfinal values.tests/runner/test_alchemical_ions.pyn the runner for the keyword schedules,ABFE schedules passed as objects, a custher custom schedule.The CI will currently fail due to the broken MKL package. I'm not going to add a pin since the issue will be fixed upstream soon. I'll just retrigger the CI when it is.