Repository navigation
Conversation
lohedges
had a problem deploying
to
biosimspace-build
October 21, 2026 13:43 — with
GitHub Actions
Failure
lohedges
had a problem deploying
to
biosimspace-build
October 21, 2026 13:43 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #557 by fixing two bugs in
BSS.Align.generateNetwork, in both the main package and the Sandpit:work_dir: theinputsandoutputssub-directories are now replaced on each call. Previously, files left over from an earlier run with a different ligand set were also loaded by LOMAP. This gave duplicate edges, self-loops, and spurious scores. It only affects a user-specifiedwork_dir, since the default is a fresh temporary directory.links_file: the rewritten links file is now actually populated. Previously it was always empty, so user-specified links were silently ignored.Regression tests have been added for both. They fail on
develand pass on this branch.It also closes #556. NAGL is now always installed via
gufe, so the tests passuse_nagl=Falseto OpenFF parameterisation to keep the reference AM1-BCC charges.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]