Skip to content

Fix issue #557 - #558

Merged
lohedges merged 2 commits into
develfrom
fix_557
Oct 21, 2026
Merged

lohedges merged 2 commits into
develfrom
fix_557

Conversation

@lohedges

@lohedges lohedges commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

This PR closes #557 by fixing two bugs in BSS.Align.generateNetwork, in both the main package and the Sandpit:

  • Stale files in a reused work_dir: the inputs and outputs sub-directories are now replaced on each call. Previously, files left over from an earlier run with a different ligand set were also loaded by LOMAP. This gave duplicate edges, self-loops, and spurious scores. It only affects a user-specified work_dir, since the default is a fresh temporary directory.
  • Ignored links_file: the rewritten links file is now actually populated. Previously it was always empty, so user-specified links were silently ignored.

Regression tests have been added for both. They fail on devel and pass on this branch.

It also closes #556. NAGL is now always installed via gufe, so the tests pass use_nagl=False to OpenFF parameterisation to keep the reference AM1-BCC charges.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have added a test for any new functionality in this pull request: [y]
  • I confirm that I have added documentation (e.g. a new tutorial page or detailed guide) for any new functionality in this pull request: [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges added the bug Something isn't working label Oct 21, 2026
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 13:43 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 13:43 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 13:43 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 14:16 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 14:16 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 14:16 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 14:16 — with GitHub Actions Active
@lohedges
lohedges deployed to biosimspace-build October 21, 2026 14:16 — with GitHub Actions Active
@lohedges
lohedges merged commit 5e8c041 into devel Oct 21, 2026
5 checks passed
@lohedges
lohedges deleted the fix_557 branch October 21, 2026 14:55
lohedges added a commit that referenced this pull request Oct 21, 2026

This branch was successfully deployed

1 active deployment
biosimspace-build — efca8107 Deployed Oct 21, 2026 by lohedges via build (3.10, linux) #415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] generateNetwork reuses stale files in work_dir and ignores links_file gufe now requires openff-nagl so it is no longer optional

1 participant