Repository navigation
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
关联 #1184。基于当前
beta继续 #1248 中 Rpeng666 提出的按需创建、播完释放方案。macOS 上,胶囊窗口挂载时会预热录音提示音。即使关闭提示音,空闲的 WebKit GPU 进程仍可能持有扬声器输出,并在播放其他声音时伴随大量 CoreAudio I/O 过载和爆音。
修复 / 新增 / 改进
AudioContext。播放结束或录音停止后释放输出,关闭提示音或卸载监听器时取消待播放请求。close()完成后,迟到的resume()又让旧上下文报告running,再次关闭旧上下文。回归测试覆盖该状态序列及连续触发时的资源清理。兼容
AudioCue.tsx和audioCue.ts。沿用当前胶囊窗口的事件订阅和设置页预览入口。测试计划
audio-cue-runtime.test.mjs、audio-cue-window-contract.test.mjs、capsule-ready-replay.test.mjs和audioCue.test.ts。aff704b1为基线。两次均关闭录音提示音且保持 OpenLess 未录音,通过同一内置扬声器用afplay播放同一个 30 秒本地 WAV。记录 Unified Log 和 CoreAudio 活跃输出客户端。外部音频停止后的约 5 秒内,未修复版继续占用输出并跳过 94 次音频周期,修复版为 0。本次实机对照以音频输出状态和系统日志为依据,覆盖上述播放复现窗口。