Skip to content

fix(settings): keep shortcut search outline intact #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
appergb wants to merge 1 commit into
base: perf/provider-prompt-cache
Choose a base branch
from
Open

fix(settings): keep shortcut search outline intact #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions openless-all/app/e2e/refinements.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,20 @@ async function openShortcuts(page: Page) {
test('shortcut search remains visible without focus', async ({ page }) => {
await openShortcuts(page);
const search = page.getByRole('searchbox', { name: '搜索命令或按键' });
await expect(search).toHaveCSS('clip-path', 'none');
await expect(search).toHaveCSS('appearance', 'none');
await expect(search).toHaveCSS('border-radius', '16px');
const colors = await search.evaluate((element) => ({
search: getComputedStyle(element).backgroundColor,
page: getComputedStyle(element.closest('.ol-settings-content') ?? document.body)
.backgroundColor,
}));
expect(colors.search).not.toBe('rgba(0, 0, 0, 0)');
expect(colors.search).not.toBe(colors.page);
await search.focus();
await expect(search).toHaveCSS('clip-path', 'none');
await search.fill('速记');
await expect(page.locator('.ol-shortcut-row')).toHaveCount(1);
});

test('awareness settings have a dedicated advanced page', async ({ page }) => {
Expand Down
3 changes: 2 additions & 1 deletion openless-all/app/src/styles/continuous-corners.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,8 @@ html
.ol-segmented-indicator,
.ol-service-view-indicator,
.ol-select-popup,
.ol-select-trigger
.ol-select-trigger,
.ol-settings-search-field
) {
clip-path: none !important;
border-radius: var(--ol-corner-radius, var(--ol-radius)) !important;
Expand Down
5 changes: 5 additions & 0 deletions openless-all/app/src/styles/refinements.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ button:disabled {

/* Search and the command list share the right-hand settings pane. */
.ol-settings-search-field {
-webkit-appearance: none;
appearance: none;
width: 100%;
min-width: 0;
height: 36px;
Expand Down Expand Up @@ -175,6 +177,9 @@ button:disabled {
.ol-shortcuts-toolbar input {
max-width: 520px;
}
.ol-shortcuts .ol-settings-search-field[type='search'] {
background-color: var(--ol-surface-2);
}
.ol-shortcuts-count {
white-space: nowrap;
color: var(--ol-ink-3);
Expand Down