Repository navigation
chore: [SDK-5607] show push subscription status in the demo app - #1783
Open
fadi-george wants to merge 1 commit into
Open
fadi-george wants to merge 1 commit into
fadi-george wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Show push subscription status in the demo app and rename the push toggle to "Opted In".
Details
Motivation
The demo only showed an "Enabled" toggle, so it was hard to tell whether the device actually had a token and permission. Part of SDK-5300 (standardize push subscription UI across SDK demo apps). Matches the Android demo (OneSignal/OneSignal-Android-SDK#2760).
Scope
Demo app only (
examples/demo). SDK unchanged. The language picker already existed.push_subscription_status, same as Android.Testing
Unit testing
No unit tests; demo UI reading existing SDK state.
Manual testing
Demo builds for the iOS simulator (
xcodebuild -scheme App). swiftlint shows only warnings that were already there. Not yet run on a device or simulator.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code