Repository navigation
Conversation
The image piped whatever foundry.paradigm.xyz served into bash. The build checks the binary's sha256 because the release assets are mutable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the
foundryupbinary that therollupcreatorimage installs, by release tag and per-arch sha256. Currently the image pipes whatever installerfoundry.paradigm.xyzserves intobash. nitro-private'sDocker buildjob rebuilds this image throughtest-node.bash --init. An upstream installer change can fail that job, which NIT-5886 makes required.foundryup_linux_<arch>from thefoundry-rs/foundryupv0.0.8releaseThe install step builds for linux/amd64 and arm64 and installs forge 1.0.0 on both. The full image builds on arm64. A wrong hash fails at
sha256sum -c.Fixes NIT-6071