Repository navigation
fix(llm): turn LiteLLM metrics on for stacks upgraded with obol upgrade - #891
Merged
Merged
Conversation
The base chart keeps an existing stack's live LiteLLM config, so older stacks only gain the Prometheus settings when obol adds them. Only `obol stack up` did; `obol upgrade`, which obolup suggested after an install, never did, so /metrics kept requiring the master key and the LLM dashboards stayed empty. - model.EnsureLiveLiteLLMObservability adds the missing settings to the live ConfigMap (never overriding operator values) and restarts LiteLLM. - obol upgrade calls it after syncing the base release; stack up calls it when its config snapshot/restore did not run. - obolup now suggests `obol stack up` for a running stack.
…tack - `obol stack up` records the obol version that brought the stack up ($CONFIG/.stack-version). - obolup, finding the stack running on an older version, explains what restarts and asks to upgrade it now (default yes). Without a terminal it only runs with --yes or OBOL_UPGRADE_STACK=true, else prints the command. - `obol doctor` gains a "Stack version" check, and other commands print a one-line notice while the stack has not been brought up by this version (not for stack/doctor/version/passthroughs, JSON or --quiet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
� v0.17.1: LiteLLM metrics on upgraded stacks, and finishing the update
�
� - LiteLLM metrics: stacks upgraded from before v0.16 with obol upgrade never gained LiteLLM's Prometheus settings, so /metrics returned 401 and the LLM dashboards were empty. obol upgrade and stack up now add any missing settings to the live config and restart LiteLLM, without overriding operator values.
� - Finishing the update: obolup offers to bring a running stack up to the version it just installed. It asks on a terminal (default yes); without one it only does so with --yes or OBOL_UPGRADE_STACK=true. obol doctor and a one-line notice on other commands flag a stack that the current CLI hasn't brought up yet.
� - Gitleaks: the known false positives are now ignored at the #888 squash commit too.