Repository navigation
Fix New-OSDCloudOSWimFile OS lookup failing for x64 targets - #392
Merged
Merged
Conversation
Co-authored-by: OSDeploy <12970006+OSDeploy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix New-OSDCloudOSWimFile error for downloading Wim
Fix New-OSDCloudOSWimFile OS lookup failing for x64 targets
Oct 2, 2026
OSDeploy
approved these changes
Oct 2, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes correctly address the reported lookup failure without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes x64 catalog lookup failures and aligns feature-update validation with supported OS targets.
Changes:
- Normalizes x64 catalog searches to amd64 and selects the latest build.
- Improves missing-OS and missing-index error handling.
- Expands supported
Get-FeatureUpdateOS names.
| File | Description |
|---|---|
Public/OSDCloudIPU/New-OSDCloudOSWimFile.ps1 |
Corrects OS and index lookup behavior. |
Public/Functions/Get-FeatureUpdate.ps1 |
Adds missing OS target values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New-OSDCloudOSWimFilefails withUnable to determine OSImageIndexand thenYou cannot call a method on a null-valued expressionfor x64 targets, the default included. The-OSNamevalues usex64, but catalogNamevalues useamd64:When nothing matched, the error path called
.replace()onIndexNames, a property OS records don't have.New-OSDCloudOSWimFile-OSNamebefore matching (x64→amd64) and selects one record, the latestBuild.Unable to find Operating System for …when no catalog record matches.IndexNamesfrom the index map instead of the OS record.Get-FeatureUpdateNew-OSDCloudOSWimFileaccepts (Windows 11 23H2 arm64,Windows 11 22H2/21H2x64/amd64,Windows 10 22H2 arm64) to the-OSNameValidateSet. Previously those inputs failed parameter validation at the download step.Known gap (not addressed)
CloudOperatingIndexMap.jsononly listsWindows 11 <Edition>keys. They now fail with a clear "Unable to determine OSImageIndex" message instead of the null-method error.