Repository navigation
Address all PR review comments - #389
Merged
Merged
Conversation
Co-authored-by: OSDeploy <12970006+OSDeploy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Address all PR review comments
Sep 30, 2026
OSDeploy
marked this pull request as ready for review
October 1, 2026 15:53
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The newly supported public GUID alias behavior is missing from the function’s parameter documentation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes cache state, setup-script safety, driver-pack GUID compatibility, diagnostics, and metadata.
Changes:
- Preserves legacy driver-pack GUIDs and aliases with test coverage.
- Corrects cache inventory state and command-file marker separation.
- Improves failure messages and catalog/help metadata.
| File | Description |
|---|---|
Public/OSDCloud/OSDCloudDriverPack.Tests.ps1 |
Tests legacy GUID alias downloads. |
Public/OSDCloud/OSDCloudDriverPack.ps1 |
Resolves canonical and legacy GUIDs. |
Public/OSDCloud.ps1 |
Clarifies image/setup failures. |
Private/steps-osd/Step-OSDCloudExpandWindowsImage.ps1 |
Clarifies thrown failure details. |
Private/steps-osd/Initialize-OSDCloudSetupScripts.Tests.ps1 |
Tests newline insertion. |
Private/steps-osd/Initialize-OSDCloudSetupScripts.ps1 |
Separates markers from existing commands. |
Private/Invoke-OSDCloudGUIDev.ps1 |
Clarifies GUI development diagnostics. |
Private/Invoke-OSDCloudGUI.ps1 |
Clarifies GUI diagnostics. |
Private/Invoke-OSDCloudCLI.ps1 |
Clarifies CLI diagnostics. |
Private/Invoke-OSDCloudAzure.ps1 |
Clarifies Azure diagnostics. |
Private/core-operatingsystem/dev/Get-OSDCloudDefaultOS.ps1 |
Corrects the 26H2 sample URL. |
Private/core-driverpack/Initialize-ModuleCoreDriverPacks.ps1 |
Documents Panasonic support. |
Private/core-driverpack/Get-OSDCloudDriverPackCompatibilityCatalog.Tests.ps1 |
Tests legacy GUID preservation. |
Private/core-driverpack/Get-OSDCloudDriverPackCompatibilityCatalog.ps1 |
Loads the legacy GUID catalog. |
Private/core-driverpack/ConvertTo-OSDCloudDriverPack.ps1 |
Preserves GUIDs and emits aliases. |
Private/core-dev/Invoke-RecastOSDCloud.ps1 |
Clarifies deployment diagnostics. |
Private/core-cache/Initialize-OSDCoreCache.Tests.ps1 |
Tests shared cache initialization. |
Private/core-cache/Initialize-OSDCoreCache.ps1 |
Uses the correct global cache variable. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| process { | ||
| foreach($Item in $Guid) { | ||
| $DriverPack = $DriverPackList | Where-Object { $_.Guid -eq $Item } | ||
| $DriverPack = $DriverPackList | Where-Object { $_.Guid -eq $Item -or $_.GuidAliases -contains $Item } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review identified stale cache inventory state, setup markers that could concatenate with existing commands, and misleading image-apply errors. It also flagged lost legacy driver-pack GUIDs and outdated help and sample metadata.
$global:OSDCoreCacheContent; add a line break before markers when existing command files lack one.