[FIX] queue_job: detect a dropped job runner connection - #1000
Open
HoloborodkoBohdan wants to merge 1 commit into
Open
HoloborodkoBohdan wants to merge 1 commit into
HoloborodkoBohdan wants to merge 1 commit into
Conversation
The job runner holds its lock on a connection that stays open. When the network drops it without closing it (firewall, NAT timeout, database failover), neither side notices: the job runner blocks in its next query until the kernel gives up retransmitting (about 15 minutes on Linux), and the database keeps the session, and so the lock, until its own TCP keepalive fires (2 hours by default). No other job runner can take over meanwhile. Enable TCP keepalives and a TCP user timeout on the connection, on the client side through the libpq parameters and on the server side through the session settings, configurable like the other jobrunner_db_* keys. Fixes OCA#984
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job runner holds its lock on a connection that stays open. When the network drops it without closing it (firewall, NAT timeout, database failover), neither side notices: the job runner blocks in its next query until the kernel gives up retransmitting (about 15 minutes on Linux), and the database keeps the session, and so the lock, until its own TCP keepalive fires (2 hours by default). No other job runner can take over meanwhile.
Enable TCP keepalives and a TCP user timeout on the connection, on the client side through the libpq parameters and on the server side through the session settings, configurable like the other jobrunner_db_* keys.
Fixes #984