Repository navigation
Incorporate pocketarc 3.4.4: get_dir_file_info() guard and Edge UA test - #19
Merged
Merged
Conversation
get_dir_file_info() wrote 'relative_path' onto the return of get_file_info() without checking it; for a broken symlink that is FALSE, triggering the PHP 8.1 "automatic conversion of false to array" deprecation (fatal in PHP 9). Such entries are now skipped. Array keys are unchanged, so there is no BC break (pocketarc PR bcit-ci#48, issue bcit-ci#47). Port test_edge() from pocketarc PR bcit-ci#50 to pin Edge vs Chrome detection order, adjusted for the local 'Edge Legacy (Spartan)' label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Status updated to applied in 7d67695. Add docs/todo/archive/ for review notes whose status is final. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates the outstanding items from pocketarc/codeigniter 3.4.4. Two of its four items (
write_log()$resultinit, Edge UA config entries) were already in this repository.Changes
get_dir_file_info()false-to-array deprecation (pocketarc PR get_metadata in Cache_file.php fails bcit-ci/CodeIgniter#48, issue "Filter segments for malicious characters", really ? bcit-ci/CodeIgniter#47) —get_file_info()returnsFALSEfor entries such as broken symlinks; writingrelative_pathonto that raised the PHP 8.1 deprecation, which becomes fatal in PHP 9. The result is now checked withis_array()and such entries are skipped.$_root_dirvariable that does not exist here and changes the array keys from basename to relative path (a BC break). Array keys are unchanged in this PR.test_edge()(pocketarc PR CI_Session Object wont store items with namespace class inheritance bcit-ci/CodeIgniter#50) — pins Edge vs Chrome detection for Chromium Edge, Legacy Edge and Android Edge. Expected legacy label adjusted to the localEdge Legacy (Spartan).docs/todo/archive/, with the status updated;docs/todo/CLAUDE.mdnow says to archive notes once their status is final.Notes
is_browser()matches on the config key, not the label: for modern Edge,is_browser('Edg')is TRUE andis_browser('Edge')is FALSE. Inherited from upstream, not changed here; the test asserts it.get_dir_file_info()keys to relative paths (which would fix same-name files in different subdirectories overwriting each other). It is a contract change and needs a separate decision.Testing
UserAgent_testandFile_helper_Testpass.Calendar_test, which also fails on the base commit without these changes (looks date-dependent).get_dir_file_info()callsrealpath(), which does not resolvevfs://paths, and dangling symlinks need elevated privileges on Windows.🤖 Generated with Claude Code