Fix Maxwell routed channel mapping - #1909
Open
Arthur031221 wants to merge 2 commits into
Open
Arthur031221 wants to merge 2 commits into
Arthur031221 wants to merge 2 commits into
Conversation
Preserve routed channel order when selecting the first mapped electrode. Keep the legacy mapping path and cover duplicate and unrouted mappings with small synthetic HDF5 fixtures. Co-authored-by: Lennart <107409831+LeMuellerGuy@users.noreply.github.com> Signed-off-by: Arthur031221 <levi74108520963@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maxwell recordings with repeated mapping channel IDs failed to load because the reader created duplicate signal IDs. The reader now follows routed channel order and keeps IDs with a single mapping entry, excluding repeated and unmapped IDs from headers and sample reads. It warns about repeated channel IDs. HDF5 buffer selection runs once so the remaining sample columns match the headers.
Picks up #1703 by @LeMuellerGuy and fixes #1702.
Added synthetic regressions for duplicate, missing and reordered mappings, empty wells, selected-channel reads and the legacy format. Tested with
pytest -q neo/test/rawiotest/test_maxwellrawio.py::TestMaxwellRawIOSynthetic neo/test/rawiotest/test_baserawio.py.Co-authored-by: Lennart 107409831+LeMuellerGuy@users.noreply.github.com