Warn instead of crashing on Neuralynx files that were not closed properly - #1908
Open
h-mayorquin wants to merge 1 commit into
Open
h-mayorquin wants to merge 1 commit into
h-mayorquin wants to merge 1 commit into
Conversation
Contributor
|
What about splitting the difference and adding this warning to #1902 but taking that. I think it's nice to get as many new contributors involved as possible. Unless you actively don't like that solution. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #1901 by @eduardosand, Cheetah writes
File was not closed properlyin place of the close time when a recording ends abruptly, and the header parsing throws an error on it. The oldNeuralynxIOalready warned on this string, but the check was lost when it was removed and the latertry/exceptfallback went away in 4cef438. This PR restores the check and leavesrecording_closedunset.There is no test because we don't have a file with this header in the testing data. I am asking for one in the issue.
This should close #1901