Fix neuroexplorer version 106 - #1907
Open
h-mayorquin wants to merge 4 commits into
Open
h-mayorquin wants to merge 4 commits into
h-mayorquin wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeuroExplorer has written
.nexversion 106 since 2011, and the reader cannot open those files when a waveform variable has a prethreshold time. This PR enables that. Version 106 added the prethreshold time, the part of each waveform snippet recorded before the threshold crossing, stored as the float64PrethresholdTimeInSeconds.So now:
UnicodeDecodeError.wf_left_sweepcarries the file's prethreshold time in samples (8 for 0.0002 s at 40 kHz) instead of a hardcoded 0.For tests I added
nonzero_prethreshold.nex, a version 106 file already on gin, cut from the vendor sample. Critically, the compliance tests were not running on any NeuroExplorer file because the attribute was misnamed: it wasfiles_to_download, and I changed it to the correctentities_to_test.