Skip to content

[NH5] Update build for nh5 - #128

Merged
StephenOman merged 20 commits into
NetHack-5-upgradefrom
update-cmake-build-for-NH5
Sep 21, 2026
Merged

StephenOman merged 20 commits into
NetHack-5-upgradefrom
update-cmake-build-for-NH5

Conversation

@StephenOman

@StephenOman StephenOman commented Jul 22, 2026 •

Copy link
Copy Markdown
Collaborator

Changes in this PR allow the C/C++ components to be built successfully.

Note: This PR contains a lot of changes so I'm happy to split it out to make it easier to review.

Changes:

  1. Updated cmake build process to include Lua capabilities (largely based on cmake support for NetHack 3.7 NetHack/NetHack#662)
  2. Remove obsolete lev_comp and dgn_comp targets
  3. Refactor rl_procs window interface to match updated NetHack 5 specification
  4. Update Python bindings including change to support the gendered names for monsters
  5. Scope & other minor changes for RNG functions to match new function locations
  6. Refactor NLE function declarations to match NH5 style (removal of macros such as NDECL, FDECL etc.)
  7. Fix the pre-commit C/C++ linter

@StephenOman

Copy link
Copy Markdown
Collaborator Author

Spoke too soon 🤬

@StephenOman
StephenOman marked this pull request as draft July 22, 2026 19:45
@StephenOman
StephenOman marked this pull request as ready for review July 30, 2026 21:00
@StephenOman

Copy link
Copy Markdown
Collaborator Author

CMake build passing correctly which is the milestone for this PR.

@StephenOman
StephenOman requested a review from heiner September 1, 2026 21:20

@heiner heiner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@StephenOman
StephenOman merged commit 2cb6379 into NetHack-5-upgrade Sep 21, 2026
11 of 19 checks passed
@StephenOman
StephenOman deleted the update-cmake-build-for-NH5 branch September 21, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants