Skip to content

CSTACKEX-345: validate storage pool capacity for volume creation #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sp16743 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CSTACKEX-345: validate storage pool capacity for volume creation #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9a067
CSTACKEX-345: validate storage pool capacity for volume creation
sp16743 Oct 14, 2026
1abc1a1
pass the storage pool cluster id into the create-volume capacity check
sp16743 Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,9 @@ private VolumeVO createVolumeOnStoragePool(Long volumeId, Long storageId) throws
throw new InvalidParameterValueException(String.format("Disk offering: %s is not compatible with the storage pool", diskOffering.getUuid()));
}

if (!storageMgr.storagePoolHasEnoughSpace(volume.getSize(), storagePool)) {
HypervisorType hypervisorType = _volsDao.getHypervisorType(volume.getId());
DiskProfile diskProfile = new DiskProfile(volume, diskOffering, hypervisorType);
if (!storageMgr.storagePoolHasEnoughSpace(Collections.singletonList(new Pair<>(volume, diskProfile)), storagePool, storagePool.getClusterId())) {
throw new InvalidParameterValueException(String.format("Storage pool %s does not have enough space to create volume %s.",
storagePool.getName(), volume.getUuid()));
}
Expand Down Expand Up @@ -1189,6 +1191,9 @@ public VolumeVO createVolume(long volumeId, Long vmId, Long snapshotId, Long sto
created = false;
VolumeInfo vol = volFactory.getVolume(volumeId);
vol.stateTransit(Volume.Event.DestroyRequested);
if (e instanceof InvalidParameterValueException) {

@sandeeplocharla sandeeplocharla Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for handling this separately?

throw (InvalidParameterValueException) e;
}
throw new CloudRuntimeException(String.format("Failed to create volume: %s", volume), e);
} finally {
if (!created) {
Expand Down
Loading